-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GTK and related dependencies to 0.18 #1137
Conversation
Update gtk and gdk to 0.18, and update related libraries to match.
glib-macros dependency is unneeded, as its contents are reexported by glib crate |
Well spotted, fixed. |
cargo wants to add 4 dependencies for some reason when using
adding them (specifically,
i am at a loss here, do you by any chance have an idea what could be causing this? my only guess is some kind of export |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1144 has been merged, this pr can now be closed
Regarding GTK4: |
Description
This PR updates GTK, GDK, and all related dependencies to 0.18.
Additionally, since
gtk
re-exportsgdk
,gdk-pixbuf
,glib
,pango
, andcairo
, it is possible (and I'd argue preferable) to depend directly on the re-exported versions. This way, we don't have to worry about keeping the versions aligned anymore - Cargo will take care of that. Notably, the re-exported version ofgdk-pixbuf
was already used everywhere, so it could just be removed without any import changes.Motivation
I'd love to see
eww
updated to GTK 4, but I understand that this is complex and time consuming, and while I wouldn't mind assisting, I don't have enough experience with GTK to be of much use.That said, what I can at least do is get the 0.17->0.18 breaking changes out of the way, and simplify the dependencies a bit to make the eventual migration ever so slightly easier.
Checklist
Please make sure you can check all the boxes that apply to this PR.
cargo fmt
to automatically format all code before committing