Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom lll linter #168

Closed
wants to merge 4 commits into from
Closed

Custom lll linter #168

wants to merge 4 commits into from

Conversation

ellemouton
Copy link
Owner

Change Description

Description of change / link to associated issue.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

Copy link

Pull reviewers stats

Stats of the last 30 days for lnd:

User Total reviews Time to review Total comments

@ellemouton ellemouton closed this Nov 29, 2024
Copy link

Pull Request Test Coverage Report for Build 12081430921

Details

  • 57 of 167 (34.13%) changed or added relevant lines in 1 file are covered.
  • 86 unchanged lines in 23 files lost coverage.
  • Overall coverage increased (+0.07%) to 59.042%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scripts/linters/lll/linter.go 57 167 34.13%
Files with Coverage Reduction New Missed Lines %
htlcswitch/mock.go 1 74.2%
sweep/fee_bumper.go 1 92.2%
channeldb/forwarding_package.go 2 75.76%
lnwallet/sigpool.go 2 65.63%
log.go 2 96.72%
contractcourt/htlc_timeout_resolver.go 2 89.27%
graph/notifications.go 2 84.62%
channeldb/channel.go 2 78.03%
rpcserver.go 2 71.07%
lnwallet/rpcwallet/rpcwallet.go 3 72.48%
Totals Coverage Status
Change from base Build 12081391037: 0.07%
Covered Lines: 133758
Relevant Lines: 226548

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant