Cleanup piecemeal #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 30 days for lnd:
|
ellemouton
force-pushed
the
cleanup-piecemeal
branch
7 times, most recently
from
b730fd2 to
c1e3f5f
Compare
Before this commit, any MuSig2Nonce TLV field used within a message is expected to use the same tlv type number. This is changed in this commit so that each message must specify which type number it wishes to use. This is necessary for if there is ever more than one MuSig2Nonce used within the same message.
This commits defines the RawFeatureVectorRecordProducer type which will allow RawFeatureVector type to be used for a TLV record.
Rename lnwire.ChannelAnnouncement to ChannelAnnouncement1. This is in preparation for the addition of a ChannelAnnouncement interface which will be implemented by both ChannelAnnouncement1 and ChannelAnnouncement2.
This is in preparation for the addition of a ChannelEdgeInfo interface which will be implemented by ChannelEdgeInfo1 and the coming ChannelEdgeInfo2.
This is in preparation for the addition of a ChannelAuthProof interface which will be implemented by ChannelAuthProof1 and the coming ChannelAuthProof2.
to lnwire.ChannelUpdate1
to ChannelEdgePolicy1
This is so that we can take the Node variable out of ChannelEdgePolicy1 so that it can be common amoung future ChannelEdgePolicy (interface) implementations.
Also adds SignMusig2 to the interface. This should be moved to it's own commit.
ellemouton
force-pushed
the
cleanup-piecemeal
branch
from
c1e3f5f to
2b691cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.