Tem #96
Closed
Tem #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let MarkEdgLive return a new ErrNotZombieEdge error if an entry with the given channel ID cannot be found. In processZombieUpdate, we then check for this error and log accordingly.
In processZombieUpdate, the SCID passed to MarkEdgeLive should _not_ be derived from the ChannelEdgeInfo ChannelID field since this field will not be populated when GetChannelByID returns a ChannelEdgeInfo along with an ErrZombieEdge error. So this commit ensures that a usable SCID is provided to processZombieUpdate.
This commit adds a new QueryOptions type which will later be used in the QueryReplyRange message.
Since the the encoding can be used for multiple different fields, we rename it here to be more generic.
This is for later when the timestamps also need to be sorted according to the SCIDs.
The `edgeIndexBucket` key name is used to key a sub-bucket within the `edgeBucket` bucket. And so the `edgeIndexBucket` is not a top level bucket.
This commit also adds a new `protocol.no-timestamp-query-option` option to disable the new behaviour.
Pull reviewers statsStats of the last 30 days for lnd:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.