Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional validation for integers #3

Closed
wants to merge 1 commit into from
Closed

Additional validation for integers #3

wants to merge 1 commit into from

Conversation

SweetDealer
Copy link
Contributor

No description provided.

* has no more than 16 digits. However, if a number has 17 digits or more, this function returns incorrect result.
* @return {{stepMismatch: boolean}}
*/
#isStepConstraintViolated() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step can exist even if we expect numbers with decimal point. I don't think we can add this validation "by default" if the step is specified.

Instead I'd create an implementation of the validator (what you call an "external" validator at the moment) and place it inside ui-essentials. And then the client code may decide to add it as a validator. It's just in this case the client code won't have to create its own implementation - it already exists in the ui-essential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants