Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common code to dedicated GitHub actions and fail the build if the lock file is not up-to-date #3272

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

caponetto
Copy link
Contributor

What changes were proposed in this pull request?

In this PR:

  • Extract Yarn installation to a dedicated action. This will facilitate future upgrades.
  • Install UI dependencies using a dedicated action that also checks whether the lock file is up-to-date or not.

How was this pull request tested?

I've tested it on my fork. When the lock file is not up-to-date, the UI-related jobs fail.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@caponetto
Copy link
Contributor Author

@lresende This is a small improvement to protect us against a dirty lock file.

… the lock file is not up-to-date

Signed-off-by: Guilherme Caponetto <[email protected]>
@lresende lresende merged commit 51ce77e into elyra-ai:main Jan 11, 2025
20 checks passed
caponetto added a commit to caponetto/opendatahub-io-elyra that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants