-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RP time driver alternatively using mtimer, timer0, timer1, or aot #3873
base: main
Are you sure you want to change the base?
RP time driver alternatively using mtimer, timer0, timer1, or aot #3873
Conversation
Why are you closing a PR, and reopening a new one with the same thing? |
I am not familiar with GitHub PRs (Just plain old GitLab.) I did not think a PR that issued error message to me is of any relevance and therefore I closed them. Is the better way to "elongate" the PR by committing something to the fork and then do (what ?) ? Anyway. Even though it now actually seems to I suppose the problem is due to the cfg Here I am not sure if I did it correctly. IMHO for the 235x the default should be the
I think,. the system tick should be somehow automatically be 1_000_000 with timer0, timer1 and mtimer, but 1_000 with aot. BTW: I can't compile the cloned repository due to |
If you commit to the same branch, the PR will be updated, and CI will run on it. However, closing and creating a new PR will send 2 messages to the matrix chat for 1700 people to see. |
Ooops :( So just committing tho the forked is enough to have you be aware of the changes (even if the pipeline fails) ? |
Should we refacture this moving the code for each hardware alternative to a dedicated module ? |
adding potential features in cargo.toml