embassy-executor: set expires_at to u64::MAX when task exits #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the task is not woken up by the time driver by setting the expires_at value to u64::MAX. This change prevents potential issues with task scheduling and ensures proper task management. FIX: embassy-rs#3875 Signed-off-by: wanglei52 <[email protected]>
|
We can't write It is intended behavior that a task can stay in the timer queue after exiting. If the timer expires when the task is not spawned it does nothing, if it expires after the user has re-spawned the task it just causes a spurious wake (spurious wakes are allowed in Rust async). It's not a "leak" because tasks are statically allocated so the memory wouldn't be reclaimed anyway, and it's not keeping the task marked as "used" so it doesn't prevent re-spawning the task. Have you run into actual issues due to this, or is this a theoretical concern? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the task is not woken up by the time driver by setting the expires_at value to u64::MAX. This change prevents potential issues with task scheduling and ensures proper task management.
FIX: #3875