Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add namespace overrides #471

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ You can customize the values of the helm deployment by using the following Value
| Parameter | Description | Default |
| ---------------------------------------- | ------------------------------------------------ | ------------------------------------------------------- |
| `nameOverride` | Overrides release name | `""` |
| `namespaceOverride` | Overrides namespace | `""` |
| `fullnameOverride` | Overrides release fullname | `""` |
| `image.repository` | Container image repository | `emberstack/kubernetes-reflector` |
| `image.tag` | Container image tag | `Same as chart version` |
Expand Down Expand Up @@ -164,4 +165,4 @@ spec:
reflector.v1.k8s.emberstack.com/reflection-allowed: "true"
reflector.v1.k8s.emberstack.com/reflection-allowed-namespaces: ""
...
```
```
8 changes: 8 additions & 0 deletions src/helm/reflector/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ Create chart name and version as used by the chart label.
{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }}
{{- end }}

{{/*
Expand the namespace of the release.
Allows overriding it for multi-namespace deployments in combined charts.
*/}}
{{- define "reflector.namespace" -}}
{{- default .Release.Namespace .Values.namespaceOverride | trunc 63 | trimSuffix "-" -}}
{{- end -}}

{{/*
Common labels
*/}}
Expand Down
2 changes: 1 addition & 1 deletion src/helm/reflector/templates/clusterRole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: {{ include "reflector.fullname" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ include "reflector.namespace" . }}
labels:
{{- include "reflector.labels" . | nindent 4 }}
rules:
Expand Down
6 changes: 3 additions & 3 deletions src/helm/reflector/templates/clusterRoleBinding.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ include "reflector.fullname" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ include "reflector.namespace" . }}
labels:
{{- include "reflector.labels" . | nindent 4 }}
roleRef:
Expand All @@ -13,5 +13,5 @@ roleRef:
subjects:
- kind: ServiceAccount
name: {{ include "reflector.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
{{- end }}
namespace: {{ include "reflector.namespace" . }}
{{- end }}
2 changes: 1 addition & 1 deletion src/helm/reflector/templates/cron.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: {{ .Values.cron.apiVersion | default "batch/v1" }}
kind: CronJob
metadata:
name: {{ include "reflector.fullname" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ include "reflector.namespace" . }}
labels:
{{- include "reflector.labels" . | nindent 4 }}

Expand Down
2 changes: 1 addition & 1 deletion src/helm/reflector/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "reflector.fullname" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ include "reflector.namespace" . }}
labels:
{{- include "reflector.labels" . | nindent 4 }}

Expand Down
2 changes: 1 addition & 1 deletion src/helm/reflector/templates/hpa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: {{ include "reflector.fullname" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ include "reflector.namespace" . }}
labels:
{{- include "reflector.labels" . | nindent 4 }}
spec:
Expand Down
2 changes: 1 addition & 1 deletion src/helm/reflector/templates/serviceaccount.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ include "reflector.serviceAccountName" . }}
namespace: {{ .Release.Namespace }}
namespace: {{ include "reflector.namespace" . }}
labels:
{{- include "reflector.labels" . | nindent 4 }}
{{- with .Values.serviceAccount.annotations }}
Expand Down
1 change: 1 addition & 0 deletions src/helm/reflector/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ image:

imagePullSecrets: []
nameOverride: ""
namespaceOverride: ""
fullnameOverride: ""

cron:
Expand Down