Merge pull request #1740 from patricklx/patch-4

enable vite windows tests

test-packages/support/suite-setup-util.ts

@@ -28,7 +28,6 @@ async function githubMatrix() {
     })),
     ...suites
       .filter(s => s.name !== 'jest-suites') // TODO: jest tests do not work under windows yet
-      .filter(s => !s.name.includes('vite-app')) // TODO: vite-app tests do not work under windows yet
       .filter(s => !s.name.includes('watch-mode')) // TODO: watch tests are far too slow on windows right now
       .map(s => ({
         name: `${s.name} windows`,

tests/scenarios/vite-app-test.ts

@@ -1,11 +1,27 @@
 import { viteAppScenarios } from './scenarios';
 import type { PreparedApp } from 'scenario-tester';
 import QUnit from 'qunit';
+import { exec } from 'child_process';
 import { readdirSync } from 'fs-extra';
 import { join } from 'path';
 
 const { module: Qmodule, test } = QUnit;
 
+// cannot use util.promisify
+// because then qunit will exit early with
+// an error about an async hold
+function execPromise(command: string): Promise<string> {
+  return new Promise(function (resolve, reject) {
+    exec(command, (error, stdout) => {
+      if (error) {
+        reject(error);
+        return;
+      }
+      resolve(stdout.trim());
+    });
+  });
+}
+
 viteAppScenarios
   .map('vite-app-basics', _project => {})
   .forEachScenario(scenario => {
@@ -16,6 +32,22 @@ viteAppScenarios
         app = await scenario.prepare();
       });
 
+      if (process.platform === 'win32') {
+        test(`correct windows path`, async function (assert) {
+          // windows sometimes generates short path alias 8.3
+          // which leads to resolving errors later
+          // e.g. cannot find owning engine for C:\Users\runneradmin\AppData\Local\Temp\tmp-2256UvRXnGotcjxi\node_modules\.embroider\rewritten-app
+          // the value in engines are:          C:\Users\RUNNER~1\AppData\Local\Temp\tmp-2256UvRXnGotcjxi\node_modules\.embroider\rewritten-app
+          // it looks like there is no way to fix this in JS with
+          // e.g fs.realpath, resolve, normalize
+          // Powershell command can be used, python could also resolve it...
+          const command = `powershell.exe -command "(Get-Item -LiteralPath '${app.dir}').FullName"`;
+          const dir = await execPromise(command);
+          app.dir = dir;
+          assert.ok(!dir.includes('~'));
+        });
+      }
+
       test(`pnpm build:ember`, async function (assert) {
         let result = await app.execute('pnpm build:ember');
         assert.equal(result.exitCode, 0, result.output);