Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move @embroider/vite typescript build to a project reference #2232

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

mansona
Copy link
Member

@mansona mansona commented Jan 21, 2025

This moves all the built files into a build/ folder and also removes the need to hand-roll the index.d.ts file 👍

@mansona mansona changed the title move vite typescript build to a project reference move @embroider/vite typescript build to a project reference Jan 21, 2025
@mansona mansona force-pushed the vite-ts-project branch 2 times, most recently from cb6a88e to a535d44 Compare January 21, 2025 10:51
Copy link
Collaborator

@void-mAlex void-mAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mansona mansona merged commit b3b53c1 into main Jan 21, 2025
211 checks passed
@mansona mansona deleted the vite-ts-project branch January 21, 2025 12:49
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants