add a simple deprecation for staticAddonTrees and staticAddonTestSupportTrees #2244
+37
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
NullVoxPopuli
approved these changes
Feb 1, 2025
void-mAlex
approved these changes
Feb 3, 2025
mansona
force-pushed
the
deprecate-static-addon-trees
branch
from
b9131f6 to
d25291a
Compare
|
We discussed merging this in spite of audit errors at the core team meeting on Tuesday 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #2207
The settings
staticAddonTreesandstaticAddonTestSupportTreesare being removed in the next version of Embroider and will effectively always be set totrue. This PR adds a message to let people know this if they are on stable Embroider and directs them to set these settings to true if they haven't already 👍