Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple matches with JsonPointerBasedFilter #22

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

dmikurube
Copy link
Member

JsonParser has not been working well with JSON Pointer for consequent multiple JSONs when used with Jackson 2.7.4+.

For example of multiple JSONs in one stream: {"a": {"b": 1}} {"a": {"b": 2}}

It happened because Jackson 2.7.3 or earlier ignored the allowMultipleMatches option. FasterXML/jackson-core#209

This commit fixes this problem by setting the option when used with Jackson 2.7.4+.

JsonParser has not been working well with JSON Pointer for consequent multiple JSONs
when used with Jackson 2.7.4+.

For example of multiple JSONs in one stream: {"a": {"b": 1}} {"a": {"b": 2}}

It happened because Jackson 2.7.3 or earlier ignored the `allowMultipleMatches` option.
FasterXML/jackson-core#209

This commit fixes this problem by setting the option when used with Jackson 2.7.4+.
@dmikurube dmikurube added this to the v0.3.0 milestone Jul 3, 2023
@dmikurube dmikurube requested a review from a team as a code owner July 3, 2023 07:01
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit ca30dca into master Jul 3, 2023
@dmikurube dmikurube deleted the allow-multiple-matches branch July 3, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants