Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lone surrogate in pike #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AnnieL01
Copy link

@AnnieL01 AnnieL01 commented Jan 6, 2025

Extend pike test to cover lone surrogate in filename.
Step 1: Create file with write/read, no delete on close
Step 2: Query file info
Step 3: Opening file with DELETE_ON_CLOSE
Step 4: Verifying file deletion

Current Implementation:
This version uses print statements to track the workflow's status at each step. Since Python's print function can raise errors when handling special surrogate characters, io.TextIOWrapper has been added to resolve this issue.
Logging Usage:
To enable log printing, use pytest -s. By default, the log-related code is commented out, and -s is not applied.

@isi-adas isi-adas self-requested a review January 6, 2025 17:41
@isi-adas
Copy link
Contributor

isi-adas commented Jan 6, 2025

cc: @isi-rszczesniak

@isi-adas
Copy link
Contributor

LGTM as a POC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants