Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix when scale replicant pod to 0, core pod can not ready #1003

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Jan 10, 2024

No description provided.

@Rory-Z Rory-Z force-pushed the fix/fix-replicant-equal-zero branch 6 times, most recently from 625b1e9 to 33d1408 Compare January 10, 2024 08:16
@Rory-Z Rory-Z force-pushed the fix/fix-replicant-equal-zero branch from 33d1408 to 0b33232 Compare January 10, 2024 09:15
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (dd376af) 77.27% compared to head (0b33232) 76.94%.

Files Patch % Lines
controllers/apps/v2beta1/update_emqx_status.go 87.50% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1003      +/-   ##
==========================================
- Coverage   77.27%   76.94%   -0.34%     
==========================================
  Files          67       67              
  Lines        6129     6141      +12     
==========================================
- Hits         4736     4725      -11     
- Misses       1169     1192      +23     
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit f88dc73 into emqx:main Jan 10, 2024
33 of 34 checks passed
@Rory-Z Rory-Z deleted the fix/fix-replicant-equal-zero branch January 10, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant