Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Symengine recipe [3.1.73] #1810

Merged
merged 12 commits into from
Jan 31, 2025
Merged

Update Symengine recipe [3.1.73] #1810

merged 12 commits into from
Jan 31, 2025

Conversation

anutosh491
Copy link
Collaborator

No description provided.

@anutosh491 anutosh491 added the 3.1.73 Emscripten v3.1.73 label Jan 30, 2025
@anutosh491
Copy link
Collaborator Author

Hmmm, I just just built symengine with boost-cpp on main few days back.
I see the 3.1.73 branch already has boost-cpp hosted. Not sure as to why it is not being found !
Any clues ?

@anutosh491
Copy link
Collaborator Author

Not sure the boost-cpp recipe is being updated on conda-forge https://github.com/conda-forge/boost-cpp-feedstock/blob/main/recipe/meta.yaml

DerThorsten
DerThorsten reviewed Jan 30, 2025
View reviewed changes
recipes/recipes_emscripten/symengine/build.sh Outdated
-DCMAKE_INSTALL_LIBDIR=lib \
-DBUILD_FOR_DISTRIBUTION=yes \
-DBUILD_SHARED_LIBS=no \
-DBoost_INCLUDE_DIR=$BUILD_PREFIX/include \
Copy link
Contributor

@DerThorsten DerThorsten Jan 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be $PREFIX here I think

Copy link
Collaborator Author

@anutosh491 anutosh491 Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I just took my changes from the main branch and pasted them here :
Didn't see any issues back there.

But yeah might be reasonable, let's try !

@anutosh491
Copy link
Collaborator Author

anutosh491 commented Jan 31, 2025 •
edited
Loading

Not sure why it looks for boost-cpp 1.80.0 in the latest failure (https://github.com/emscripten-forge/recipes/actions/runs/13069263252/job/36467155746). This channel only has access to 1.87.0

I think pyodide had boost-cpp 1.84.0 and they haven't updated after that
So on main last week I updated the recipe from 1.80.0 to 1.84.0 ( I didn't notice you had made the move to 1.87.0 on the 3.1.73 branch)

And then I used the 1.84.0 build to build symengine on main. That worked very smoothly (and then I just pasted those changes here)

@DerThorsten DerThorsten merged commit 0c3ef79 into emscripten-forge:emscripten-3.1.73 Jan 31, 2025
1 check passed
@anutosh491 anutosh491 deleted the symengine-3.1.73 branch January 31, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerThorsten DerThorsten DerThorsten left review comments

Assignees
No one assigned
Labels
3.1.73 Emscripten v3.1.73
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anutosh491 @DerThorsten