Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENYO-6473: Enhance ImageItem rendering performance #375

Closed
wants to merge 4 commits into from

Conversation

ybsung
Copy link
Contributor

@ybsung ybsung commented May 29, 2020

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

ImageItem rendering time is higher when scrolling in VirtualList.

Resolution

The main root cause is one rendering so many React Elements again. So I tried to cache the React Elements and re-rendered only children prop or some props with a CacheReactElementContext.

Additional Considerations

Links

ENYO-6473
Related PR: enactjs/enact#2777

Comments

Enact-DCO-1.0-Signed-off-by: YB Sung ([email protected])

ybsung added 3 commits May 29, 2020 10:16
Enact-DCO-1.0-Signed-off-by: YB Sung ([email protected])
Enact-DCO-1.0-Signed-off-by: YB Sung ([email protected])
Enact-DCO-1.0-Signed-off-by: YB Sung ([email protected])
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ybsung
Copy link
Contributor Author

ybsung commented Oct 29, 2021

Due to Contributor License Agreement, I'd like to close this PR.

@ybsung ybsung closed this Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants