Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodl support #339

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ETeissonniere
Copy link

@ETeissonniere ETeissonniere commented Apr 8, 2022

Add support for the nodl coin. Depends on ensdomains/crypto-addr-serialize/pull/11.

@Arachnid Arachnid requested a review from makoto April 14, 2022 04:29
@makoto
Copy link
Member

makoto commented Jun 16, 2022

Hi.
Your test seems failing even though I locally linked crypto-addr-codec to ensdomains/crypto-addr-serialize#11

  ● NODL

    TypeError: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received nullTypeError [ERR_INVALID_ARG_TYPE]: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received null

      618 | 
      619 | function ksmAddrDecoder(data: string): Buffer {
    > 620 |   return Buffer.from(ss58Decode(data));
          |                 ^
      621 | }
      622 | 
      623 | function nodlAddrEncoder(data: Buffer): string {

      at Object.ksmAddrDecoder [as decoder] (src/index.ts:620:17)
      at Object.<anonymous> (src/__tests__/index.test.ts:1261:30)


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants