Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entgql): add input field directives #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danicc097
Copy link

based on an old #543 and #469 concept and adds a complete example.

Fixes ent/ent#3407

some tests had to be updated to accommodate the new table

example use case:

field.Enum("role").
	Values("USER", "ADMIN", "MODERATOR").
	Default("USER").
	Annotations(entgql.Directives(
		hasRoleDirective(user.RoleADMIN).OnCreateMutationField().OnUpdateMutationField().SkipOnTypeField(),
	)),

which makes the field queryable but not editable unless admin.

The workaround right now is a schema hook like so, which may be error prone with e.g. forgetting clear and append and also gets out of hand quickly even if we abstract this to nested maps of directives where we also may forget to add/delete/modify a key.

entgql.WithSchemaHook(func(_ *gen.Graph, s *ast.Schema) error {
			for _, typ := range []string{"CreateUserInput", "UpdateUserInput"} {
				for _, name := range []string{"role"} {
					f := s.Types[typ].Fields.ForName(name)
					if f == nil {
						return fmt.Errorf("missing query field %q", name)
					}
					d := schema.HasRoleDirective(user.RoleADMIN)
					f.Directives = append(f.Directives, &ast.Directive{
						Name:      d.Name,
						Arguments: d.Arguments,
					})
				}
			}
			return nil
		}),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entgql: possibility to attach custom directives to mutation create and update inputs
1 participant