Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add support for azapi #208

Merged
merged 4 commits into from
Nov 24, 2024
Merged

Feat: add support for azapi #208

merged 4 commits into from
Nov 24, 2024

Conversation

TomerHeber
Copy link
Collaborator

@TomerHeber TomerHeber commented Nov 21, 2024

resolves #207

Added support azapi provider.
Added a new test.

Copy link
Member

@eranelbaz eranelbaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for azapi where there are no tags?

@TomerHeber
Copy link
Collaborator Author

Can you add a test for azapi where there are no tags?

I updated the tests and added resources with no tags.
It works like the rest of the providers. I'm unsure there's any benefit in adding anything else, but let me know...

@TomerHeber TomerHeber requested a review from eranelbaz November 22, 2024 14:05
@eranelbaz
Copy link
Member

I just wanted to be on the safe side since we have two options

  • Tags already there and we want to append
  • No Tags block and we need to create one

@TomerHeber
Copy link
Collaborator Author

I just wanted to be on the safe side since we have two options

  • Tags already there and we want to append
  • No Tags block and we need to create one

makes sense!
I have added these.

@TomerHeber TomerHeber merged commit 1992269 into master Nov 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for azapi
2 participants