Feat: azapi - not all resources support tags #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Nov 30, 2024
| @@ -0,0 +1,42 @@ | |||
| from io import StringIO | |||
There was a problem hiding this comment.
this is the utility for parsing the html file and building the white list.
TomerHeber
commented
Nov 30, 2024
TomerHeber
commented
Nov 30, 2024
| once sync.Once | ||
| ) | ||
|
|
||
| func getAzureTaggableResources() map[string]bool { |
There was a problem hiding this comment.
parse the csv file...
TomerHeber
commented
Nov 30, 2024
| @@ -51,14 +84,65 @@ func GetTagIdByResource(resourceType string) string { | |||
| return "" | |||
| } | |||
|
|
|||
| func IsSupportedResource(resourceType string) bool { | |||
| func isSimpleStringLiteral(tokens hclwrite.Tokens) (string, bool) { | |||
There was a problem hiding this comment.
extracts the 'type' value.
TomerHeber
commented
Nov 30, 2024
internal/providers/providers.go
Outdated
| return "", false | ||
| } | ||
|
|
||
| func azureTypeIsTaggable(resource hclwrite.Block) bool { |
There was a problem hiding this comment.
check based on the white list if the 'type' is taggable.
TomerHeber
commented
Nov 30, 2024
| } | ||
|
|
||
| resource "azapi_resource" "example4" { | ||
| type = "Microsoft.App/containerApps/authConfigs@2024-03-01" |
There was a problem hiding this comment.
authConfig isn't taggable.
TomerHeber
commented
Nov 30, 2024
| } | ||
|
|
||
| resource "azapi_resource" "example4" { |
There was a problem hiding this comment.
should remain untaggable.
eranelbaz
reviewed
Dec 2, 2024
eranelbaz
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Microsoft's documentation a whitelist of resources was created.
Only azapi types (type field) in the white list will be tagged.
fixes #209