Create releases for go-control-plane (0.13.4) and envoy API (1.32.3) #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
reviewed
Jan 3, 2025
| @@ -1,11 +1,11 @@ | |||
| module-sets: | |||
| go-control-plane: | |||
| version: v0.13.2 | |||
| version: v0.13.4 | |||
There was a problem hiding this comment.
0.13.3 was already created in the old model for the go.mod issue (technicality to ensure we can release 13.4 without forcing go 1.22.8 on dependents)
https://github.com/envoyproxy/go-control-plane/releases/tag/v0.13.3
mmorel-35
previously approved these changes
Jan 3, 2025
|
The build is failing, any idea ? |
I think this is a dead end right now. I can cut the tags from this branch, as the rebase and merge should not alter the commits (if I rebase before as the envoy sync got fixed and just altered main) |
Signed-off-by: Valerian Roche <[email protected]>
Signed-off-by: Valerian Roche <[email protected]>
valerian-roche
force-pushed
the
vr/0.13.4
branch
from
82b67b2 to
e7169a6
Compare
|
Just rebased on main. Will tag from here once approved |
Signed-off-by: Valerian Roche <[email protected]>
valerian-roche
force-pushed
the
vr/0.13.4
branch
from
e7169a6 to
46e0318
Compare
mmorel-35
approved these changes
Jan 4, 2025
|
Pushed the commits and tags on main. Hopefully should recover the issues |
|
PR directly merged on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates new releases that will hopefully address #1074
This PR will NOT build as is, given the tags not being pushed yet