Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePickers]: improve a11y focus flow behavior #2427

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

AlekseyManetov
Copy link
Collaborator

@AlekseyManetov AlekseyManetov commented Jul 25, 2024

Issue link(if exists): #2421

Description:

Now date picker body receive focus on open and return it back on input after close.

Copy link

github-actions bot commented Jul 25, 2024

Generated by: track-bundle-size
Generated at: Fri, 26 Jul 2024 10:21:07 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.8.1-alpha.0 (2024-06-14)
CI Status: ok

Module Baseline Size
(v5.8.1-alpha.0)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 747.12 750.99 +3.88
js:+0.28
css:+3.59
🆗 672.4 - 821.83
@epam/app 6506.94 6607.37 +100.43
js:+60.61
css:+39.81
🆗 5856.24 - 7157.63
@epam/draft-rte 53.79 53.77 -0.02
js:-0.01
css:-0.01
🆗 48.41 - 59.17
@epam/electric 4.57 4.57 0
js:0
css:0
🆗 4.12 - 5.03
@epam/promo 53.9 55.66 +1.76
js:0
css:+1.76
🆗 48.51 - 59.29
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 89.5 92.09 +2.59
js:+0.01
css:+2.58
🆗 80.55 - 98.45
@epam/uui-components 256.5 259.48 +2.98
js:+2.95
css:+0.03
🆗 230.86 - 282.16
@epam/uui-core 330.34 331.01 +0.67
js:+0.67
css:0
🆗 297.3 - 363.37
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 206.19 206.75 +0.56
js:+0.56
css:+0.01
🆗 185.57 - 226.81
@epam/uui-editor 176.98 181.56 +4.58
js:+4.67
css:-0.09
🆗 159.28 - 194.68
@epam/uui-timeline 47.18 47.17 0
js:0
css:0
🆗 42.46 - 51.9
@epam/uui 591.14 592.83 +1.69
js:+0.27
css:+1.42
🆗 532.03 - 650.25
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.8.4",
  "timestamp": "2024-07-26",
  "sizes": {
    "templateApp": {
      "css": 287610,
      "js": 481407
    },
    "@epam/app": {
      "css": 1645844,
      "js": 5120098
    },
    "@epam/draft-rte": {
      "css": 9770,
      "js": 45292
    },
    "@epam/electric": {
      "css": 2275,
      "js": 2409
    },
    "@epam/promo": {
      "css": 46063,
      "js": 10936
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 51745,
      "js": 42558
    },
    "@epam/uui-components": {
      "css": 22270,
      "js": 243440
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 338956
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 2450,
      "js": 209262
    },
    "@epam/uui-editor": {
      "css": 12504,
      "js": 173418
    },
    "@epam/uui-timeline": {
      "css": 2254,
      "js": 46054
    },
    "@epam/uui": {
      "css": 268435,
      "js": 338623
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

Amount
Types 295 (+0) 🆗
Props 233 (+0) 🆗

@siarheiyelin siarheiyelin force-pushed the datePicker-focus-improvements branch from 8f7d6c2 to cc21a67 Compare July 26, 2024 10:14
@AlekseyManetov AlekseyManetov merged commit 70393cc into develop Jul 29, 2024
4 checks passed
@NatalliaAlieva
Copy link
Collaborator

Released in 5.9.0 ver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants