Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PresetsPanel]: Fixed icons being cut off and dropdown not scrolling #2731

Conversation

siarhei-epam
Copy link
Collaborator

@siarhei-epam siarhei-epam commented Jan 13, 2025

Description:

  • [DropdownMenuBody]: added maxHeight prop
  • [DropdownMenuButton]: fixed cropping of icons located to the right of the text
  • [PresetsPanel]: added scroll to More dropdown

Issue link:

#2708

QA notes:

@siarhei-epam siarhei-epam self-assigned this Jan 13, 2025
@siarhei-epam siarhei-epam changed the title [DropdownMenuItem]: fixed cropping of icons located to the right of the text [DropdownMenuButton]: fixed cropping of icons located to the right of the text Jan 13, 2025
Copy link

github-actions bot commented Jan 13, 2025

Generated by: track-bundle-size
Generated at: Wed, 15 Jan 2025 14:46:43 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.11.0 (2024-11-22)
CI Status: ok

Module Baseline Size
(v5.11.0)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 767.47 777.55 +10.08
js:+1.45
css:+8.63
🆗 690.72 - 844.21
@epam/app 5631.71 5905.28 +273.57
js:+264.78
css:+8.79
🆗 5068.53 - 6194.88
@epam/draft-rte 53.78 53.03 -0.75
js:-0.74
css:-0.01
🆗 48.41 - 59.17
@epam/electric 4.58 4.58 0
js:0
css:0
🆗 4.12 - 5.04
@epam/promo 55.24 55.46 +0.23
js:0
css:+0.23
🆗 49.71 - 60.76
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 91.19 90.68 -0.51
js:-0.74
css:+0.23
🆗 82.07 - 100.31
@epam/uui-components 264.19 269.4 +5.2
js:+5.06
css:+0.15
🆗 237.77 - 290.61
@epam/uui-core 338.13 338.06 -0.07
js:-0.07
css:0
🆗 304.32 - 371.94
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 176.28 181.25 +4.96
js:+4.95
css:+0.01
🆗 158.65 - 193.91
@epam/uui-editor 184.43 181.75 -2.68
js:-2.67
css:0
🆗 165.98 - 202.87
@epam/uui-timeline 80.98 81.78 +0.8
js:+0.85
css:-0.05
🆗 72.88 - 89.08
@epam/uui 611.83 621.1 +9.27
js:+3.17
css:+6.1
🆗 550.64 - 673.01
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.12.1",
  "timestamp": "2025-01-15",
  "sizes": {
    "templateApp": {
      "css": 311964,
      "js": 484249
    },
    "@epam/app": {
      "css": 740359,
      "js": 5306642
    },
    "@epam/draft-rte": {
      "css": 9770,
      "js": 44536
    },
    "@epam/electric": {
      "css": 2275,
      "js": 2416
    },
    "@epam/promo": {
      "css": 47375,
      "js": 9424
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 53354,
      "js": 39504
    },
    "@epam/uui-components": {
      "css": 22657,
      "js": 253203
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 346173
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 2455,
      "js": 183139
    },
    "@epam/uui-editor": {
      "css": 12741,
      "js": 173369
    },
    "@epam/uui-timeline": {
      "css": 2203,
      "js": 81538
    },
    "@epam/uui": {
      "css": 286582,
      "js": 349420
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

Amount
Types 301 (+0) 🆗
Props 233 (+0) 🆗

[PresetsPanel]: added scroll to 'More' dropdown
@siarhei-epam siarhei-epam changed the title [DropdownMenuButton]: fixed cropping of icons located to the right of the text [PresetsPanel]: Fixed icons being cut off and dropdown not scrolling Jan 15, 2025
@AlekseyManetov AlekseyManetov merged commit f8604c4 into develop Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants