Add support for pattern alternatives #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I am very puzzled why those princess solver tests fail if they did not fail before. |
This is indeed puzzling... Princess using tests seem more fragile, we got this problem on other PRs too |
|
We investigated and these tests failing have nothing to do with your PR. It is happening because of the latest release of the Princess Solver. We will ignore those tests in a soon-to-be-merged PR. |
Co-authored-by: SidonieBouthors Co-authored-by: Mai-LinhC <[email protected]>
Co-authored-by: SidonieBouthors <[email protected]> Co-authored-by: Mai-LinhC <[email protected]>
Co-authored-by: SidonieBouthors <[email protected]> Co-authored-by: Mai-LinhC <[email protected]>
Co-authored-by: SidonieBouthors <[email protected]> Co-authored-by: Mai-LinhC <[email protected]>
samuelchassot
force-pushed
the
better-pattern-alternative
branch
from
ebc41cd to
f657ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #1128 and #617 by adding support for pattern alternatives in Stainless.
This was done in the context of our project in the Formal Verification CS-550 course. This version adds a new Alternative pattern and handles it throughout the pipeline and therefore allows disjunctions of patterns to be used.
Note: This does not yet add support for pattern alternatives in the Coq encoder or GenC, but does include support for pattern alternatives when using the optional simplifiers OL and OCBSL.