Skip to content

Commit

Permalink
GHA: Update actions/upload-artifact to v4
Browse files Browse the repository at this point in the history
  • Loading branch information
@ralphlange
ralphlange committed Dec 16, 2024
1 parent 73c2544 commit 614e0b7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci-scripts-build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,11 @@ jobs:
run: grep . cfg/*
- name: Upload tapfiles Artifact
if: ${{ always() }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: tapfiles ${{ matrix.name }}
path: '**/O.*/*.tap'
if-no-files-found: ignore

docker:
name: ${{ matrix.name }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/python.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ jobs:
run: ls dist/*

- name: Save Artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: epicscorelibs
path: dist/*
Expand Down Expand Up @@ -380,7 +380,7 @@ jobs:
run: ls dist/*

- name: Save Artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: epicscorelibs
path: dist/*
Expand Down

3 comments on commit 614e0b7

@mdavidsaver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ralphlange Did I miss a PR being merged?

fyi. this change broke the python build which depended on the now removed behavior of upload-artifact to merge when multiple artifacts have the same name.

@mdavidsaver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GHA failures fixed with 0a2313d

@ralphlange
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdavidsaver No, you didn't. I'm sorry - that was my bad.

I didn't create a branch - as the changes were trivial - and must have pushed to the (tracked) origin instead of a personal fork without intent or even noticing.
Thanks for the fix, which removes the need to revert my commit.

I'm working on fixing the other broken builds that showed up - most of them were broken for a while but didn't run for months. The AppVeyor turn-around times make those fixes a challenge in patience.

Please sign in to comment.