Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ioc: improve group processing warning messages. #90

Merged
merged 2 commits into from
Dec 12, 2024
Merged

ioc: improve group processing warning messages. #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c1806c
ioc: improve group processing warning messages.
ericonr Nov 22, 2024
fcd9e30
ioc: fix typo in warning message.
ericonr Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ioc/groupconfigprocessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ void GroupConfigProcessor::defineFields(GroupDefinition& groupDefinition, const
}

if(fieldName.empty() && fieldConfig.info.type!=MappingInfo::Meta) {
fprintf(stderr, "%s.%s Error: only +type:\"meta\" map be mapped at struct top\n",
fprintf(stderr, "%s.%s Error: only +type:\"meta\" can be mapped at struct top\n",
groupName.c_str(), fieldName.c_str());
continue;
}
Expand Down
8 changes: 3 additions & 5 deletions ioc/groupprocessorcontext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ void GroupProcessorContext::assign(const Value& value) {
groupPvConfig.structureId = value.as<std::string>();

} else {
groupConfigProcessor->groupProcessingWarnings += "Unknown group option ";
groupConfigProcessor->groupProcessingWarnings += field;
groupConfigProcessor->groupProcessingWarnings += SB()<<"Unknown group option: \""<<field<<"\"\n";
}
field.clear();

Expand All @@ -59,7 +58,7 @@ void GroupProcessorContext::assign(const Value& value) {
} else if(tname == "const") {
type = MappingInfo::Const;
} else {
groupConfigProcessor->groupProcessingWarnings += SB()<<"Unknown mapping +type:\""<<tname<<"\" ignored";
groupConfigProcessor->groupProcessingWarnings += SB()<<"Unknown mapping +type:\""<<tname<<"\" ignored\n";
}
groupField.info.type = type;

Expand All @@ -82,8 +81,7 @@ void GroupProcessorContext::assign(const Value& value) {
groupField.info.cval = value;

} else {
groupConfigProcessor->groupProcessingWarnings += "Unknown group field option ";
groupConfigProcessor->groupProcessingWarnings += field + ":" + key;
groupConfigProcessor->groupProcessingWarnings += SB()<<"Unknown group field option: \""<<field<<":"<<key<<"\"\n";
}
key.clear();
}
Expand Down
Loading