-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added global handler #11
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
===========================================
+ Coverage 40.94% 76.73% +35.79%
===========================================
Files 21 22 +1
Lines 359 374 +15
===========================================
+ Hits 147 287 +140
+ Misses 212 87 -125 ☔ View full report in Codecov by Sentry. |
Thanks Max. Please could you take a look at why the CI is failing (this is a great exercise in how we do python projects!). Because this is a python copier template project, like most python projects at DLS you can run all the CI checks locally using You could also probably update this project to the latest copier template. Instructions again in the above docs. Sometimes CI errors are picking up on issues with changes dependencies and updating to latest copier template is good practice anyway. To see the CI errors you are getting look in the actions tab of the github repo. |
PS - one of your failures is code coverage, you could add a test that demonstrates the new feature to fix this. |
That's better - the tests are passing now - but you still have a linting error with regards to type checks. Should be quite easy to fix but let me know if you need any advice on this. |
Awesome, thanks! |
Added globalhandler function to make ioc-non-specific changes.