Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added global handler #11

Merged
merged 9 commits into from
Oct 8, 2024
Merged

Added global handler #11

merged 9 commits into from
Oct 8, 2024

Conversation

MaxHerbs
Copy link
Contributor

@MaxHerbs MaxHerbs commented Oct 3, 2024

Added globalhandler function to make ioc-non-specific changes.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 76.73%. Comparing base (0d53bdb) to head (eef8375).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/builder2ibek/convert.py 33.33% 10 Missing ⚠️
src/builder2ibek/converters/dlsPLC.py 0.00% 2 Missing ⚠️
src/builder2ibek/converters/digitelMpc.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #11       +/-   ##
===========================================
+ Coverage   40.94%   76.73%   +35.79%     
===========================================
  Files          21       22        +1     
  Lines         359      374       +15     
===========================================
+ Hits          147      287      +140     
+ Misses        212       87      -125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gilesknap
Copy link
Member

gilesknap commented Oct 3, 2024

Thanks Max.

Please could you take a look at why the CI is failing (this is a great exercise in how we do python projects!). Because this is a python copier template project, like most python projects at DLS you can run all the CI checks locally using tox -p, see:
https://diamondlightsource.github.io/python-copier-template/main/how-to/dev-install.html

You could also probably update this project to the latest copier template. Instructions again in the above docs. Sometimes CI errors are picking up on issues with changes dependencies and updating to latest copier template is good practice anyway.

To see the CI errors you are getting look in the actions tab of the github repo.

@gilesknap
Copy link
Member

PS - one of your failures is code coverage, you could add a test that demonstrates the new feature to fix this.

@gilesknap
Copy link
Member

That's better - the tests are passing now - but you still have a linting error with regards to type checks.

Should be quite easy to fix but let me know if you need any advice on this.

@gilesknap
Copy link
Member

Awesome, thanks!

@gilesknap gilesknap merged commit cb62298 into epics-containers:main Oct 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants