Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to make p46 GigE cameras work #2

Merged
merged 3 commits into from
Jan 3, 2024
Merged

changes to make p46 GigE cameras work #2

merged 3 commits into from
Jan 3, 2024

Conversation

subinsaji
Copy link
Contributor

No description provided.

@subinsaji subinsaji requested a review from gilesknap January 3, 2024 14:48
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (f923028) 84.80% compared to head (4a452d9) 79.87%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/builder2ibek/converters/BL46P-BUILDER.py 23.07% 10 Missing ⚠️
src/builder2ibek/convert.py 80.76% 5 Missing ⚠️
src/builder2ibek/builder.py 50.00% 4 Missing ⚠️
src/builder2ibek/converters/epics_base.py 25.00% 3 Missing ⚠️
src/builder2ibek/converters/ADAravis.py 50.00% 1 Missing ⚠️
src/builder2ibek/converters/ADZMQ.py 75.00% 1 Missing ⚠️
src/builder2ibek/converters/ffmpegServer.py 75.00% 1 Missing ⚠️
src/builder2ibek/types.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   84.80%   79.87%   -4.93%     
==========================================
  Files          15       18       +3     
  Lines         283      333      +50     
==========================================
+ Hits          240      266      +26     
- Misses         43       67      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gilesknap gilesknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first PR to the epics-containers org!

merging now ...

@gilesknap gilesknap merged commit d091e4a into main Jan 3, 2024
11 checks passed
@gilesknap gilesknap deleted the p46-changes branch January 21, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants