Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create seperate services, iocs maps #33

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

marcelldls
Copy link
Contributor

Changes the expected format of the values.yaml so that the labeling of ec-service can be done in the background and clear separation between services that may have enabling/disabling implemented

services:
  epics-pvcs:
  epics-opis:

iocs:
  b01-1-ea-test-01:
    targetRevision: 2024.9.1

Additional optimisation:

  • Replace $currentScope for just $

@gilesknap
Copy link
Member

It occurs to me that non-iocs may choose to support the enabled flag.
Do we want to allow them to be controlled by ec? I don't see why not.

If we decide yes, then maybe the iocs map needs a different name?
@DiamondJoseph @coretl do you have an opinion on thsi?

@marcelldls marcelldls merged commit 9f72782 into handle-enabled-flag Oct 3, 2024
5 checks passed
@marcelldls marcelldls deleted the services-iocs-split branch October 3, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants