refactor: DKMS RPM #125
refactor: DKMS RPM #125
Conversation
|
@lucmaga , just the lookup to our conversation. |
jerzyjamroz
force-pushed
the
dkms-rpm
branch
4 times, most recently
from
96a2a72 to
e490696
Compare
| @@ -0,0 +1,2 @@ | |||
| # UDEV rule giving access to MRF device | |||
| KERNEL=="uio*", ATTR{name}=="mrf-pci", GROUP="@@DRV_GROUP@@", MODE="0660", RUN+="/bin/chmod g+rw %S%p/resource0 && /bin/logger UDEV rule giving access to MRF device %S%p" | |||
There was a problem hiding this comment.
@jerzyjamroz , does that chmod is necessary ? My understanding is that the MODE defined should change the permission
There was a problem hiding this comment.
chmod changes other resource but there is an issue in Centos7, I leave this for eventual future improvement, mostly for the Yocto test.
mrmShared/linux/dkms-rpm/CONFIG
Outdated
| # Specify the group for the MRF driver user here | ||
|
|
||
| # NOTE: group root can be adjusted by the configuration tool | ||
| DRV_GROUP := root |
There was a problem hiding this comment.
Does make sense to have the default group as root ? I would except that root is not the common case, as the users might access the driver with common users
There was a problem hiding this comment.
This is an open question. I think it can be configured by any configuration tool after the installation.
There was a problem hiding this comment.
Group "mrf" and "660" implemented.
|
One last question, would that change generate an automatic rpm on the CI ? |
The latest kmod build with the latest kernel removed from the standard verification as it was generating the error state.
* VERSION changed to CONFIG as it contains more vars now. * PKG_NAME introduced. * RPM_RELEASE generic for any rpm based distro.
@mdavidsaver , I did refactoring as follows: