Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Packaging mrf dkms as a deb package #128

Merged
merged 1 commit into from
Feb 21, 2024
Merged

feat: Packaging mrf dkms as a deb package #128

merged 1 commit into from
Feb 21, 2024

Conversation

gabrielfedel
Copy link
Contributor

@gabrielfedel gabrielfedel commented Feb 15, 2024

This is a PR of the the debian packaging for mrf dkms, and it is my first debian package so sorry if there is something too unconventional.

With this PR it is possible to build a .deb package that works for Debian (tested on 10) and Ubuntu (tested on 22.04).

Some important points:

  • I chose to not use the information available on CONFIG (as it is used by rpm) as for debian package we have to keep the changelog file, so sounded better to not have any automatic filling. That means that the debian package should be updated when there are new kernel driver releases.
  • Regarding the version, I chose to use the defined version (3) and the way debian version the packages, resulting in the first version as 3-0.
  • The package name is mrf-dkms, as the module is loaded as mrf. That looks the right choice as it seems was the used one on other similar works to have it as a debian package
  • The list of authors was got using git shortlog -sne ./mrmShared/linux and removing duplicated names

@gabrielfedel gabrielfedel changed the title draft: feat: Packaging mrf dkms as a deb package feat: Packaging mrf dkms as a deb package Feb 16, 2024
@gabrielfedel gabrielfedel force-pushed the dkms-deb2 branch 2 times, most recently from fa56dee to 9958da9 Compare February 16, 2024 08:32
@gabrielfedel
Copy link
Contributor Author

I'm trying to rename the package to mrfioc2-dkms, but this make the installation process attached to that name and it looks for a mrfioc2.ko (it might be ways to work around that but I'm not finding them) . Any suggestions on how to proceed ? Move the driver to mrfioc2 ? or keep the package as mrf-dkms ? Or a third option ?

@gabrielfedel gabrielfedel changed the title feat: Packaging mrf dkms as a deb package draft: feat: Packaging mrf dkms as a deb package Feb 19, 2024
@jerzyjamroz
Copy link
Contributor

I changed the .rpm accordingly: #129
If there is another preference then comments are welcome. It would be good to keep the consistency across different package types.

@jerzyjamroz jerzyjamroz changed the title draft: feat: Packaging mrf dkms as a deb package feat: Packaging mrf dkms as a deb package Feb 19, 2024
@jerzyjamroz
Copy link
Contributor

@lucmaga , support the review.

@gabrielfedel
Copy link
Contributor Author

Ok, the package is ready to be reviewed.

@gabrielfedel gabrielfedel self-assigned this Feb 20, 2024
@lucmaga
Copy link

lucmaga commented Feb 20, 2024

Tested on Ubuntu also, works as expected.
Only thing I would add, maybe it does not fit in this PR, is to automatically do it using CI for the releases.

Anyway, LGTM.

@gabrielfedel gabrielfedel merged commit cbd5988 into master Feb 21, 2024
17 checks passed
@gabrielfedel gabrielfedel deleted the dkms-deb2 branch February 21, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants