VME EVM-300 changes #52
Conversation
afpietryla
force-pushed
the
aps
branch
5 times, most recently
from
a152e24 to
865e222
Compare
| @@ -68,7 +68,7 @@ record(longin , "$(P)Prescaler-RB") { | |||
| field( DTYP, "Obj Prop uint32") | |||
| field( INP , "@OBJ=$(OBJ), PROP=Prescaler") | |||
| field( DESC, "EVG Mux Prescaler RB") | |||
| field( FLNK, "$(SYS){$(D)}ResetMxc-Cmd") | |||
| field( FLNK, "$(SYS):$(D):ResetMxc-Cmd.PROC") | |||
There was a problem hiding this comment.
The preferred way to chase out NSLS2 naming convention out of .db files is with a macro to avoid breaking vme-evg230-nsls2.substitutions and other existing subtitutions.
Also, why the addition of .PROC?
There was a problem hiding this comment.
I didn't intend to change the pvname here. I added the .PROC field to quite a warning message.
There was a problem hiding this comment.
In this instance the "Forward-link uses Channel Access ..." warning is actually an error. This link is intended to be local.
|
GIthub no longer running builds. |
|
If you can rebase you will pick up the new configuration for github actions. |
|
This is weird, GitHub actions has run the build for Tony's repo after he rebased, but it isn't even noticing the new commits here, let alone running the actions. Are you aware of some kind of a quota which epics-modules might have run out of? |
|
Maybe an approval thing? I don't see an "Approve and run" button, but I'm not sure if I am an admin for the |
|
There is definite weirdness. I get an error "Unable to re-run disabled workflow. " when I try to re-run that last successful build. |
|
Ok, maybe my doing. I was experimenting with scheduling a "monthly" build as "surveillance" for dependency problems. However, it seems that GHA will helpfully disable the workflow if there has been no repository activity in the past 60 days. Thank you GHA. I'll be removing this... mrfioc2/.github/workflows/ci-scripts-build.yml Lines 23 to 24 in 0ce5346 I've re-enabled the workflows, and started re-running the last jobs. Nothing has changed with this PR, but that might happen on the next push. |
|
@hongran @afpietryla The commit e2f9306 that Ran just pushed to this branch needs to be removed or backed out, these changes are not appropriate for this pull request, which is anchored to the github branch. |
|
I believe I addressed all your comments. Please review again. Thanks. |
|
I believe I addressed all your comments. Please review again. Thanks. |
|
@hongran once you are ready, please issue the close request for this PR. |
Add support for GitHub Actions
Included are the changes I've made so far to add support for the VME version of the EVM-300.
I am particularly interested in how to handle the changes for the last commit, so that backward compatibility is maintained.