Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulser trigger with DBus bits and prescalers #61

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

ZanMaticPratnemer
Copy link
Contributor

Add prescaler and DBus bit triggers for pulsers

@ZanMaticPratnemer ZanMaticPratnemer changed the title Pulser trig Pulser trigger with DBus bits and prescalers Oct 6, 2022
@ZanMaticPratnemer ZanMaticPratnemer marked this pull request as draft October 7, 2022 08:04
@ZanMaticPratnemer ZanMaticPratnemer marked this pull request as ready for review October 7, 2022 11:24
@jerzyjamroz jerzyjamroz self-assigned this Oct 17, 2023
@jerzyjamroz jerzyjamroz self-requested a review October 17, 2023 11:03
@jerzyjamroz jerzyjamroz force-pushed the pulser-trig branch 2 times, most recently from 98987a5 to e04c156 Compare October 19, 2023 14:40
@jerzyjamroz
Copy link
Contributor

@ZanMaticPratnemer , it is an interesting PR, I tried to run it with EVR DlyGen-1-DBusTrig-Sel set to a 14Hz DBus bit from EVG and it gets continuously retriggered while the DBus bit is high (so half of the 14Hz cycle). Is there a way to configure it just for the DBus rising edge?
What is the application that you have been using this DBusTrig, and in which scenario? I will try to use the same config for the tests.

@ZanMaticPratnemer
Copy link
Contributor Author

@zioven might have more insight into these specifics.

@jerzyjamroz jerzyjamroz marked this pull request as draft October 27, 2023 12:59
@jerzyjamroz
Copy link
Contributor

jerzyjamroz commented Nov 20, 2023

@zioven , @ZanMaticPratnemer, does this implementation is for the generic FPGA image e.g. mTCA-EVR-300DC-18180207.bit (or a modification)? What was the image version used during your tests?

@zioven
Copy link
Contributor

zioven commented Nov 24, 2023

@jerzyjamroz this is part of the standard FPGA image, is available in mTCA-EVR-300DC-18180207.bit and even some earlier versions (we have been using this feature with stock FW since 2020).

I have also found this in the manual:
image

and here is an example of Jukka's implementation in his API:
https://github.com/jpietari/mrf-linux-api/blob/master/api/erapi.c#L1084

@jpietari can probably elaborate since when this is available in the FW ...

@zioven
Copy link
Contributor

zioven commented Dec 15, 2023

@jerzyjamroz

Please review and merge if this changes are acceptable.

@zioven
Copy link
Contributor

zioven commented Jan 5, 2024

@jerzyjamroz can this be merger or is there anything missing from this pull request?

@jerzyjamroz
Copy link
Contributor

@zioven , nominal operation tests: #61 (comment)
I will try to do that next week.

@zioven
Copy link
Contributor

zioven commented Jan 5, 2024

@ZanMaticPratnemer , it is an interesting PR, I tried to run it with EVR DlyGen-1-DBusTrig-Sel set to a 14Hz DBus bit from EVG and it gets continuously retriggered while the DBus bit is high (so half of the 14Hz cycle). Is there a way to configure it just for the DBus rising edge? What is the application that you have been using this DBusTrig, and in which scenario? I will try to use the same config for the tests.

We are testing the DBUS triggers with the following configuration:

  1. On EVM:

Set the MXC4 Prescaler to provide the 10 kHz frequency
Trigger DBus bit 4 from MXC4

  1. On EVR:

Output 1 [labeled DlyGen+DBus]: Triggered by Delay Generator (pulser) with following parameters

  • width: 1 us
  • delay: 0 us
  • source: DBus bit 4
$ caget -0b TS-KG:{EVR1-DlyGen:4}DBusTrig-Sel
TS-KG:{EVR1-DlyGen:4}DBusTrig-Sel 10000
$ caget -0x TS-KG:{EVR1-DlyGen:4}DBusTrig-Sel
TS-KG:{EVR1-DlyGen:4}DBusTrig-Sel 0x10
$ caget TS-KG:{EVR1-DlyGen:4}DBusTrig-Sel
TS-KG:{EVR1-DlyGen:4}DBusTrig-Sel 16

Output 2 [labeled: DBus]: Triggered by DBus Bit 4

image

@jerzyjamroz jerzyjamroz marked this pull request as ready for review January 8, 2024 11:55
@jerzyjamroz jerzyjamroz merged commit ae2cd16 into epics-modules:master Jan 8, 2024
11 checks passed
@zioven zioven deleted the pulser-trig branch January 8, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants