-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace cases
by confirm
for API consistency
#131
Comments
In principle having common names makes sense. I think {EpiNow2} should change its requirements for column names as 'cases' alongside 'deaths' is IMO clearer to users; 'confirm' is ambiguous. In practice, changing requirements in either package would be a breaking change, and therefore difficult to justify for uniformity's sake. |
Thanks, I hadn't seen that issue! Again, in practice, if we do decide to standardise, it does make make sense for {cfr} to change its requirement to match {EpiNow2} - if the new name makes sense - as there are far fewer {cfr} users (I imagine) so lower impact overall. |
Hi @avallecam - could I get an idea if this issue is still relevant or if it can be closed? |
I'll look at this at the end of this week again. |
May {cfr} and {EpiNow2} be facing a similar situation? the count column of their input data could contain many types of
Following Gosnic et al., Fig 4, The column name of From a learning point of view:
I suggest to keep this issue open and wait for {EpiNow2} to see how they generalize the column name and evaluate to replicate in {cfr}. A similar column name may facilitate to visualize the relationship and flexibility of these two packages. In the meantime, we may want to increase the visibility of the alternative |
Thanks @avallecam, I'll keep this issue open for now. |
Wondering if for consistency across the ecosystem,
{cfr}
and{EpiNow2}
should use a similar column name. Data from {cfr} can also be used for {EpiNow2} right?Created on 2024-03-19 with reprex v2.1.0
The text was updated successfully, but these errors were encountered: