Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make serial argument a string instead of a function #50

Closed
jamesmbaazam opened this issue Aug 31, 2023 · 0 comments · Fixed by #188
Closed

Make serial argument a string instead of a function #50

jamesmbaazam opened this issue Aug 31, 2023 · 0 comments · Fixed by #188

Comments

@jamesmbaazam
Copy link
Member

jamesmbaazam commented Aug 31, 2023

Instead of requiring that, and in the spirit of what I understand to be the underlying issue (offspring and serial calling for different approaches), how about changing serial to take a character string (with corresponding random and distribution functions expected to be present in the environment)? My sense is that this would be simpler.

Originally posted by @sbfnk in #25 (comment)

From the conversation in #25, the general agreement was about the inconsistent requirements for specifying the serial and offspring distributions. We have agreed to make the argument for specifying the serial distribution expect a string instead of making the offspring distribution argument expect a function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant