Config refactor #102
Merged
Config refactor #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes :already_started error
provides additional message when raising error
now configured in runtime
use get_env_or_raise/_with_message use defaults in System.get_env cast port string to integer
System.get_env defaults
works the same in all envs remove from config/config move from prod in runtime
done per env
configuration now happens in init() and is called in config/runtime.exs
+ remove extra comment
when running in dev or test, this is a useful default production should set it to true when necessary
…lication env use ExUtils.Map.atomize_keys/2 when loading configs from database add warning to use atom keys
…ions allows config to be updated on restart
extracts code from config warmer; loads config from env and stores to db then returns config as map with string keys
when configs are loaded from env, they are also returned from db create call, so keys are string in that case as well: atomize them
akinsey
approved these changes
Aug 6, 2024
|
🎉 This PR is included in version 1.32.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves env-configurable parts of project to config/runtime
consolidates configurations and improves automatic/default handling of different environments (dev, test, prod)
standardizes frontend config to store to database as a map with string keys and load into env as a map with atom keys
configure rate limiter within its own module (may change in the future)