Move thread #103
Merged
Move thread #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontinued, add comments more queries in transaction
… last post info given a board id
… post position info correctly
…to top level board
…tadataboard) return
unenglishable
requested changes
Aug 20, 2024
| ACL.bypass_post_owner( | ||
| user, | ||
| post, | ||
| "threads.move", |
There was a problem hiding this comment.
will review this myself to check if we can simplify arguments
| thread = build(:thread, board: board, user: user) | ||
| _thread_posts = build_list(num_thread_replies, :post, user: user, thread: thread.post.thread) |
There was a problem hiding this comment.
would be good to validate return values using this variable - otherwise it can be removed, and use a comment instead
…rd fixture, it is irrelevant
unenglishable
approved these changes
Aug 22, 2024
|
🎉 This PR is included in version 1.34.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.