Fix move thread test refactor #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storing higher precision date time allows test results to be accurate changes models to use :naive_datetime_usec and changeset functions use NaiveDateTime.utc_now() without truncating subject to change; especially in `lib/epochtalk_server/models/post.ex` where code sets `now = now`
updates to timestamp precision in created_at/updated_at no longer require custom timestamp to be inserted
move data for "move" test into the test update comments to make them more descriptive
akinsey
requested changes
Sep 9, 2024
unenglishable
force-pushed
the
fix-move-thread-test-refactor
branch
from
029c76d to
27c46c8
Compare
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor to improve test handling
changes naivedatetime's at
secondprecision tousecreverts changes to models and factories that add functionality for specifying
created_attime.adapting
usecusage eliminates the need to sequence thread/post creationmoves data creation for
thread movetest into the test itself, simplifyingsetup()and reducingcomplexity that could lead to issues when writing future tests