-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12 UI add support for platform urls #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform:
URL.For
platform:
URL support an EclipseRDFModel class should be used instead of RDFModel. The EclipseRDFModel has some additional processing added for converting incompatibleplatform:
URLs tofile:
(both data and schema lists checked and converted). Processing of the Model URL lists (data & schema) is done using existing Java and Eclipse facilities, notably, Eclipse's runtime FileLocator, is used to resolve the location of a Model file on the system's file system.With the
platform:
protocol support, changes to the Model Edit dialogue have been made. Adding model files from the Workspace (button) now adds aplatform:
URL instead of afile:
. This should help improve the portability of launch configurations between systems.To test the processing of the URLs an additional set of Junit tests have been added. This also required the addition of a small class that can create an Eclipse Project workspace for tests to be run. When testing under an Eclipse Project space any model files being accessed by Jena in the tests must be copied into the project workspace and the file system must be synchronised with the project, before the test is executed.
platform:
URLs check the conversion of a good URL by loading and model then querying with Jena.platform:
URL is performed, and the errors report "no file path" which vaguely refers to the URL conversion process not finding the files at the given URL (i.e. platform URL doesn't point to a file).file:
'.' '/' URLs are tested to confirm they work, again a model is loaded and queried.