Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15 start a mof2rdf aware variant of the driver #27

Merged
merged 21 commits into from
Feb 3, 2025
Merged

15 start a mof2rdf aware variant of the driver #27

merged 21 commits into from
Feb 3, 2025

Conversation

OwenR-York
Copy link
Contributor

To support different flavours of RDFModels like MOF2RDF, specific pairs of Model and Resource type extensions will be used.

Property "gets" happen through the RDFResource class, before invoking the more general propertyGetter. Therefore, the type and creation of Resources need to be adapted to enable different getProperty results processing.

Change how RDFModel creates RDFResources

  • RDFModel.java - Add createResource()
  • Replace all references to new Resource with createResource()
  • Check tests are passing

Create MOF2RDF extensions for (RDF) Model and Resource

  • MOF2RDFModel.createResource() should return a MOF2RDFResource
  • MOF2RDFResource.getProperty() should override RDFModel.getProperty with "MOF2RDF" property processing (call super now, change processes later).
  • Duplicate a set of tests that use MOF2RDFModel in place of RDFModel (no changes to functionality yet)

Change getProperty() on RDFResourcel and MOF2RDFResource

  • Remove the Max Cardinality processing from RDFResource to MOF2RDF.getProperty()
  • Correct the RDFTest results, which no should not follow "Max Cardinality"
  • Check tests

Create EclipseMOF2RDFModel extension

  • Separate the Protocol parser from EclipseRDFModel
  • Duplicate the EclipseRDFModel but for MOF2RDFModel types

UI updates

  • Add a new MOF2RDF Model type to the ADD model button
  • Add a Dialogue (duplicate RDFModelConfigurationDialog)

@OwenR-York
createRDFResource() replacing new RDFResource
c688a5b
@OwenR-York
MOF2RDF Model Resource and initial test set added
2fe6c95
@OwenR-York
Refactoring getProperty() added getCollectionOfPropertyValues()
81dcc93 
Resource is now public to enable extensions of RDFResource access.

listPropertyValues doesn't need to be public.

Removed the MaxCardinality checking and value return processing.

Reordered the methods involved in the getProperty process, to try and
improve readability. This entire chain of methods could do with a
refactor at some point.
@OwenR-York
Added the Max Cardinality checking and value return to MOF2RDFResource
3b78b26
@OwenR-York
Changed the RDFOWLReasonerTests over to MOF2RDFModel (same tests)
7ab9394
@OwenR-York
Updated the expected results for the RDFModelOWLReasonerTests
9abcfc1 
The RDFModel uses RDFResources which do not apply Cardinality checking,
so we always get an ArrayList in an Object back. Thus, the results need
to check the number of properties returned, not types or error messages.
@OwenR-York
Update the model test results RDFResource (prior change to getProperty)
34b93c5
@OwenR-York
Separated protocol parser from EclipseRDFModel
e1bdae6
@OwenR-York
Duplicate EclipseRDFModel to EclipseMOF2RDFModel
a727833
@OwenR-York
Add MOF2RDF type (same Dialogue as RDFModel)
603b30a
@OwenR-York
Copyrights
f93b27c
@OwenR-York
Clean up TODOs and Console output
40bcefd
@OwenR-York
unused import clean up
26901f2
@OwenR-York
MOF2RDF Dialogue and update to Example OWL demo
8657ad3
@OwenR-York OwenR-York linked an issue Jan 31, 2025 that may be closed by this pull request
Start a MOF2RDF-aware variant of the driver #15
Closed
@agarciadom agarciadom merged commit 6fd8f1d into main Feb 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start a MOF2RDF-aware variant of the driver
2 participants
@OwenR-York @agarciadom