Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable ETH and STRK fee token addresses #2477

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Conversation

vbar
Copy link
Contributor

@vbar vbar commented Jan 9, 2025

Using fee token addresses returned by get_contract_addresses feeder gateway endpoint (instead of hard-coded ones), iff Pathfinder calls that endpoint - that is, for custom networks.

Fixes #2453 .

@vbar vbar requested a review from a team as a code owner January 9, 2025 16:05
@vbar vbar changed the title configurable ETH and STRK fee token addresses feat: configurable ETH and STRK fee token addresses Jan 9, 2025
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbar vbar merged commit 8effb94 into main Jan 10, 2025
8 checks passed
@vbar vbar deleted the vbar/token-addr-config branch January 10, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ETH and STRK fee token addresses configurable
2 participants