Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky p2p sync test #2503

Merged
merged 3 commits into from
Jan 21, 2025
Merged

flaky p2p sync test #2503

merged 3 commits into from
Jan 21, 2025

Conversation

CHr15F0x
Copy link
Member

@CHr15F0x CHr15F0x commented Jan 20, 2025 •
edited
Loading

This PR fixes 2 things:

  • syncing fake contract update which does not have a valid underlying class hash is a recoverable error, not a fatal one,
  • removes flakiness from a related test, by improving how sync done watch works.

@CHr15F0x CHr15F0x changed the title Chris/flaky sync test flaky p2p sync test Jan 20, 2025
@CHr15F0x CHr15F0x marked this pull request as ready for review January 20, 2025 21:23
@CHr15F0x CHr15F0x requested a review from a team as a code owner January 20, 2025 21:23
kkovaacs
kkovaacs approved these changes Jan 21, 2025
View reviewed changes
crates/pathfinder/src/sync.rs Outdated Show resolved Hide resolved
@CHr15F0x @kkovaacs
fixup: typo in error message
75b371f 
Co-authored-by: KOVACS Krisztian <[email protected]>
t00ts
t00ts approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@t00ts t00ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CHr15F0x CHr15F0x merged commit 243842b into main Jan 21, 2025
8 checks passed
@CHr15F0x CHr15F0x deleted the chris/flaky-sync-test branch January 21, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t00ts t00ts t00ts approved these changes

@kkovaacs kkovaacs kkovaacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CHr15F0x @kkovaacs @t00ts