fix(executor): fix L2 gas computation and inner-call gas estimation #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, make sure _not_ to use recursive VM resources for inner calls.
kkovaacs
force-pushed
the
krisztian/call-level-gas-calculation
branch
from
4a6a4b7 to
c44c8d1
Compare
This calculation now properly uses the gas vector computation mode.
Just like we had in pre-0.8 JSON-RPC versions transaction traces in JSON-RPC 0.8 will also have inner call gas consumtion values that include the costs of all sub-calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes inner-call gas usage estimation for transaction traces. On the JSON-RPC 0.8 interface we now return
l1_gasandl2_gascost estimation for inner calls instead of the raw VM resources (which are not available anyway when running with L2 gas).We now determine the gas vector computation mode (whether to use L2 gas) from the resource bounds in the transaction and then consistently use that when computing costs.