Disable cppcoreguidelines-avoid-do-while check and fix NOLINTEND issues

equeim · Aug 23, 2024 · fb283a0 · fb283a0
1 parent ce14bb9
commit fb283a0
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 9 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -16,6 +16,7 @@ Checks: >
   -cppcoreguidelines-owning-memory,
   -cppcoreguidelines-pro-type-static-cast-downcast,
   -cppcoreguidelines-non-private-member-variables-in-classes,
+  -cppcoreguidelines-avoid-do-while
   -cppcoreguidelines-avoid-non-const-global-variables,
   -cppcoreguidelines-avoid-const-or-ref-data-members,
   -cppcoreguidelines-macro-usage,

diff --git a/src/coroutines/coroutines_test.cpp b/src/coroutines/coroutines_test.cpp
@@ -249,6 +249,8 @@ namespace tremotesf {
     };
 }
 
+// NOLINTEND(cppcoreguidelines-avoid-reference-coroutine-parameters)
+
 QTEST_GUILESS_MAIN(tremotesf::CoroutinesTest)
 
 #include "coroutines_test.moc"
diff --git a/src/itemlistupdater_test.cpp b/src/itemlistupdater_test.cpp
@@ -15,8 +15,6 @@
 #include "itemlistupdater.h"
 #include "stdutils.h"
 
-// NOLINTBEGIN(cppcoreguidelines-avoid-do-while)
-
 struct Item {
     int id;
     QString data;

diff --git a/src/log/demangle_test.cpp b/src/log/demangle_test.cpp
@@ -6,8 +6,6 @@
 
 #include "demangle.h"
 
-// NOLINTBEGIN(cppcoreguidelines-avoid-do-while)
-
 using namespace tremotesf;
 
 struct Foo {};

diff --git a/src/rpc/pathutils_test.cpp b/src/rpc/pathutils_test.cpp
@@ -7,8 +7,6 @@
 
 #include "pathutils.h"
 
-// NOLINTBEGIN(cppcoreguidelines-avoid-do-while)
-
 using namespace tremotesf;
 
 class PathUtilsTest final : public QObject {

diff --git a/src/rpc/requestrouter_test.cpp b/src/rpc/requestrouter_test.cpp
@@ -37,7 +37,7 @@ using namespace tremotesf::impl;
         throw std::exception();                                              \
     } while (false)
 
-// NOLINTBEGIN(bugprone-unchecked-optional-access, cppcoreguidelines-avoid-do-while)
+// NOLINTBEGIN(bugprone-unchecked-optional-access)
 
 namespace {
     constexpr auto testApiPath = "/"_l1;
@@ -542,6 +542,8 @@ namespace {
     };
 }
 
+// NOLINTEND(bugprone-unchecked-optional-access)
+
 QTEST_GUILESS_MAIN(RequestRouterTest)
 
 #include "requestrouter_test.moc"
diff --git a/src/rpc/tracker_test.cpp b/src/rpc/tracker_test.cpp
@@ -10,8 +10,6 @@
 #include "tracker.h"
 #include "torrent.h"
 
-// NOLINTBEGIN(cppcoreguidelines-avoid-do-while)
-
 using namespace tremotesf::impl;
 
 class TrackerTest final : public QObject {