Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSTring type #794

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Add SSTring type #794

merged 1 commit into from
Jan 27, 2025

Conversation

SethDusek
Copy link
Collaborator

@SethDusek SethDusek commented Dec 10, 2024

Add String type, some transactions use this despite it not being very useful (only bin_ops Eq, Neq are implemented)
Closes #791

@SethDusek SethDusek marked this pull request as ready for review December 19, 2024 04:20
@SethDusek SethDusek requested a review from kushti December 19, 2024 04:20
@SethDusek SethDusek force-pushed the sstring branch 2 times, most recently from 88b4d44 to dc95df4 Compare January 4, 2025 09:19
@coveralls
Copy link

coveralls commented Jan 4, 2025

Pull Request Test Coverage Report for Build 12858692080

Details

  • 15 of 39 (38.46%) changed or added relevant lines in 5 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 78.439%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ergotree-ir/src/serialization/data.rs 7 8 87.5%
ergotree-ir/src/mir/value.rs 0 3 0.0%
ergotree-ir/src/types/stype.rs 1 4 25.0%
ergotree-ir/src/mir/constant.rs 5 12 41.67%
ergotree-ir/src/serialization/types.rs 2 12 16.67%
Files with Coverage Reduction New Missed Lines %
ergotree-ir/src/mir/value.rs 1 57.24%
ergotree-ir/src/serialization/types.rs 11 78.77%
Totals Coverage Status
Change from base Build 12853076213: -0.1%
Covered Lines: 11125
Relevant Lines: 14183

💛 - Coveralls

Add String type, some transactions use this despite it not being very useful (only bin_ops Eq, Neq are implemented)
@SethDusek SethDusek merged commit 6b471c3 into ergoplatform:develop Jan 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't parse mainnet tx with SSTring
3 participants