Modify upload model to dockerhub workflow to support backward compatibility #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhanshreeA
force-pushed
the
66-modify-upload-model-to-dockerhub-workflow-to-support-backward-compatibility
branch
from
37a128b to
36889c9
Compare
DhanshreeA
deleted the
66-modify-upload-model-to-dockerhub-workflow-to-support-backward-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
This PR introduces a lot of changes. The upload-model-to-dockerhub workflow first tries to build a model's image using Ersilia Pack, if it fails, and if the model is packed using the legacy format, then the workflow tries building with Multi Stage + Conda Pack approach, and finally, failing both these approaches, the Legacy BentoML approach is utilized.
The Multi Stage + Conda Pack approach, and Legacy BentoML approach are packed into a single parameterized callable workflow at
upload-bentoml.yml, while Ersilia Pack model build is packed intoupload-ersiliapack.yml.Finally, the actions that run post model image upload are refactored into a new workflow because I could not manage to create an execution graph where a job with those actions would run if any one of the model building approaches had worked.