Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --track flag to the Test built image step in the Docker build pipeline for Ersilia models #70

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

AnushkaShreyam
Copy link
Contributor

@AnushkaShreyam AnushkaShreyam commented Oct 17, 2024

Description:

This pull request updates the Docker build pipeline for Ersilia models by running the models with the --track flag during the "Test built image" step.

Changes include:

Ersilia Pack: Updated the Docker pipeline to run Ersilia models with the --track flag during the "Test built image" step.
BentoML: Integrated the --track flag in the testing step when running Ersilia models using BentoML.

This change ensures better tracking and reporting of model runs during the Docker build process, allowing for more robust monitoring and debugging capabilities.
Why this change is necessary:

The --track flag improves model run monitoring by enabling logging and tracking, which can help with performance evaluation and debugging.
This ensures that both Ersilia Pack and BentoML models follow the same testing practices, maintaining consistency across different toolsets.

Testing:

Tested the Docker pipeline for both Ersilia Pack and BentoML models to ensure that the --track flag functions as expected during the "Test built image" step.
Verified that logs and tracking data are properly generated and accessible after the test runs.

Related:

This pull request is related to issue #925 in a ersilia repository, where a similar implementation for automatic testing of the --track flag was introduced. Although the issue pertains to a different repo, the changes here are aligned with that effort to streamline testing and tracking across platforms.

@DhanshreeA DhanshreeA merged commit 7b723fd into ersilia-os:main Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants