Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependencies related to ersilia test module #1238

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

DhanshreeA
Copy link
Member

@DhanshreeA DhanshreeA commented Aug 22, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description
Marking Scikit Learn, and Scipy as optional because those are only required by the ersilia test module to make the basic ersilia install lightweight.

@DhanshreeA DhanshreeA merged commit ce4600d into master Aug 22, 2024
18 of 19 checks passed
@DhanshreeA DhanshreeA deleted the cleanup-dependencies branch August 22, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant