Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving concurrency conflcts during fetching operation #1243

Closed
wants to merge 1 commit into from

Conversation

Malikbadmus
Copy link
Contributor

@Malikbadmus Malikbadmus commented Aug 25, 2024

Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed

  • Have you followed the guidelines in our Contribution Guide
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Description

A session ID mechanism to manage resource allocation during fetching, ensuring the successful execution of models running simultaneously across different sessions.

Changes to be made

Updated the tmp directory prefix to include Session PID.

Status

Simultaneous fetching of models from different sources now works seamlessly. Ersilia no longer attempts to shut down Docker containers for models pulled from Docker Hub running in other sessions.

To do

Resolve concurrency conflicts in serving and running predictions.

Related to #1197

@Malikbadmus
Copy link
Contributor Author

It appears this also resolved the conflicts during model serving and prediction. I ran several tests with different models simultaneously, and everything now works smoothly.

@miquelduranfrigola
Copy link
Member

@DhanshreeA feel free to merge the PR. I did not look into it in detail.

@DhanshreeA DhanshreeA closed this Sep 17, 2024
@Malikbadmus Malikbadmus deleted the session_conflicts branch January 7, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants